-
Notifications
You must be signed in to change notification settings - Fork 62
chore(jetbrains-gateway): make agent_name unused
#383
Conversation
|
Working properly on dogfood with https://dev.coder.com/templates/coder/coder/versions/stupefied_archimedes6 |
agent_name unusedagent_name unused
agent_name unusedagent_name unused
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
Co-authored-by: Muhammad Atif Ali <[email protected]>
|
@matifali I was wondering, is there a way to add a warning to a template so that the template admins will notice? |
|
You can probably hack something using a I was also thinking about a similar feature to read logs from arbitrary sources and inject them in startup logs. If we do something like that we can expand the scope to choose the sink of the logs to be either build logs (i.e. terraform) or agent logs (i.e. |
|
@matifali providers also support emitting warnings: I think a |
|
Ahh wait we tried this once already, did something change about the ID? It did not work before because the ID here (of the resource, I think it was changing every rebuild) is not necessarily the same as the ID in the API response (of the agent in the database, this one I think was not changing). |
@phorcys420 have you tested by rebuilding/restarting the workspace too? |
I haven't, I only tried starting it once, i'll check if it works. |


agent_nameis not necessary in the URL when the agent ID is provided, this PR aims to remove the need to specify the agent's name to improve the UX of the module.